[CALCITE-6266] Parser should be able to parse cross join with left lateral

[snuyanzin]

No description provided.

[sonarcloud]

Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

[jeyhunkarimov]

Thanks for the PR @snuyanzin .
I have a few comments.

From the Calcite's parenthesized sub-clause in JOIN PR (CALCITE-35) also from the Parser.jj file in the main branch, I see:

        // Comma joins should only occur at top-level in the FROM clause.
        // Valid:
        //  * FROM a, b
        //  * FROM (a CROSS JOIN b), c
        // Not valid:
        //  * FROM a CROSS JOIN (b, c)

So, this query - select * from dept cross join ((VALUES ('A'), ('B')), (VALUES ('A'), ('B'))) should not pass (and it fails in the main branch). However, with this PR it passes. Am I missing sth?

Also, this query - select * from dept cross join ( lateral table(ramp(dept.deptno)) cross join (VALUES ('A'), ('B')) ) also fails with the exception Table 'DEPT' not found. We might need to investigate if this is an expected behaviour.

[JiajunBernoulli]

Why change it?

[snuyanzin]

yep, that I also realised this is an issue...

Would be great to hear any ideas how we can cope with the original parser issue