Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: install netcat-openbsd instead of netcat in test image build #4476

Merged
merged 1 commit into from
Jul 29, 2024
Merged

fix: install netcat-openbsd instead of netcat in test image build #4476

merged 1 commit into from
Jul 29, 2024

Conversation

shoothzj
Copy link
Member

No description provided.

@shoothzj shoothzj mentioned this pull request Jul 28, 2024
Open
@lhotari
Copy link
Member

lhotari commented Jul 28, 2024 

 The command '/bin/sh -c wget -nv https://archive.apache.org/dist/zookeeper/bookkeeper/bookkeeper-4.1.0/bookkeeper-server-4.1.0-bin.tar.gz{,.sha1,.md5,.asc}' returned a non-zero code: 8

It looks like the command doesn't get properly expanded. I wonder if using bash shell would address the problem.

@shoothzj
Copy link
Member Author

@lhotari I change FROM eclipse-temurin:8-jdk to FROM eclipse-temurin:8-jdk-jammy, to keep style consistent with other ubuntu docker image.

@lhotari
Copy link
Member

lhotari commented Jul 29, 2024

@lhotari I change FROM eclipse-temurin:8-jdk to FROM eclipse-temurin:8-jdk-jammy, to keep style consistent with other ubuntu docker image.

Oh yes, makes sense. It seems that things broken when eclipse-temurin switched to use Ubuntu 24.04 (noble) base image. Switching to jammy (22.04) makes the existing commands to work.

@shoothzj shoothzj merged commit 5662524 into apache:master Jul 29, 2024
23 checks passed
@shoothzj shoothzj deleted the fix-netcat branch July 29, 2024 06:33
hangc0276 pushed a commit that referenced this pull request Aug 5, 2024
@shoothzj @hangc0276
fix: install netcat-openbsd instead of netcat in test image build (#4476
ff12a56 
)

Signed-off-by: ZhangJian He <[email protected]>
(cherry picked from commit 5662524)
hangc0276 pushed a commit that referenced this pull request Aug 5, 2024
@shoothzj @hangc0276
fix: install netcat-openbsd instead of netcat in test image build (#4476
cfa5cb1 
)

Signed-off-by: ZhangJian He <[email protected]>
(cherry picked from commit 5662524)
hangc0276 pushed a commit that referenced this pull request Aug 5, 2024
@shoothzj @hangc0276
fix: install netcat-openbsd instead of netcat in test image build (#4476
66e84ad 
)

Signed-off-by: ZhangJian He <[email protected]>
(cherry picked from commit 5662524)
horizonzy pushed a commit to horizonzy/bookkeeper that referenced this pull request Aug 5, 2024
@shoothzj @horizonzy
fix: install netcat-openbsd instead of netcat in test image build (ap…
199fc9e 
…ache#4476)

Signed-off-by: ZhangJian He <[email protected]>
(cherry picked from commit 5662524)
hangc0276 pushed a commit that referenced this pull request Aug 5, 2024
@horizonzy @shoothzj
[Branch-4.15] Fix ReadOnlyLedgerHandle leak issue when checkAllLedgers (
f5872c1 
#4470)

* Fix ReadOnlyLedgerHandle leak issue when checkAllLedgers.

* fix: install netcat-openbsd instead of netcat in test image build (#4476)

Signed-off-by: ZhangJian He <[email protected]>
(cherry picked from commit 5662524)

---------

Co-authored-by: ZhangJian He <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lhotari lhotari lhotari approved these changes

Assignees
No one assigned
Labels
area/tests cherry-picked/branch-4.15 cherry-picked/branch-4.16 cherry-picked/branch-4.17 release/4.15.6 release/4.16.7 release/4.17.2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shoothzj @lhotari @hangc0276