[BugFix] Fix to prevent resource leaks in 3 classes #4449
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dlg99
reviewed
Jun 28, 2024
| @@ -180,23 +180,24 @@ private synchronized BufferedLogChannel allocateNewLog(File dirForNextEntryLog, | |||
| } while (testLogFile == null); | |||
|
|
|||
| File newLogFile = new File(dirForNextEntryLog, logFileName); | |||
| FileChannel channel = new RandomAccessFile(newLogFile, "rw").getChannel(); | |||
| try (FileChannel channel = new RandomAccessFile(newLogFile, "rw").getChannel()) { | |||
There was a problem hiding this comment.
is it a good idea to close the channel here? it is used by the logChannel that is being returned
There was a problem hiding this comment.
Reverted changes for this file
dlg99
approved these changes
Jul 3, 2024
shoothzj
reviewed
Jul 4, 2024
There was a problem hiding this comment.
It seems we have been leaked some resources for long, really? Need more eyes. @nicoloboschi @hangc0276 @nodece
nodece
approved these changes
Jul 4, 2024
Looks like it. We should take care of it. |
shoothzj
approved these changes
Jul 4, 2024
shoothzj
requested changes
Jul 4, 2024
fu-turer
approved these changes
Jul 4, 2024
nicoloboschi
approved these changes
Jul 4, 2024
dk2k
changed the title
shoothzj
approved these changes
Jul 6, 2024
|
Thanks for your contribution! |
Ghatage
pushed a commit
to sijie/bookkeeper
that referenced
this pull request
Jul 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented try-with-resources for instances of Autocloseable