-
Notifications
You must be signed in to change notification settings - Fork 903
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[client] new API to check if Bookkeeper client is connected to metadata service #4342
Merged
shoothzj
merged 14 commits into
apache:master
from
congbobo184:feature/add_check_zk_interface
Jul 26, 2024
Merged
Changes from 10 commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
131a89c
Add interface for Bookkeeper client to check metadata service is avai…
b4a7b44
fix code style
315b4af
fix some comment
5f3aaa2
fix some comment
e5a2438
fix some comment
c7c905f
fix some test and fix some comment
9c8ccf6
fix some comment
91e400a
remove the sync
7d9e9a6
remove the sync
b60341e
delete blank line
4db75f8
fix some comments, delete the default implementation
ef2419a
Merge remote-tracking branch 'apache/master' into feature/add_check_z…
36ee703
fix code style
0f39efd
revert unnecessary change
shoothzj File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
52 changes: 52 additions & 0 deletions
52
...er/src/test/java/org/apache/bookkeeper/client/api/DriverMetadataServiceAvailableTest.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,52 @@ | ||
/* | ||
* | ||
* Licensed to the Apache Software Foundation (ASF) under one | ||
* or more contributor license agreements. See the NOTICE file | ||
* distributed with this work for additional information | ||
* regarding copyright ownership. The ASF licenses this file | ||
* to you under the Apache License, Version 2.0 (the | ||
* "License"); you may not use this file except in compliance | ||
* with the License. You may obtain a copy of the License at | ||
* | ||
* http://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, | ||
* software distributed under the License is distributed on an | ||
* "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
* KIND, either express or implied. See the License for the | ||
* specific language governing permissions and limitations | ||
* under the License. | ||
* | ||
*/ | ||
package org.apache.bookkeeper.client.api; | ||
|
||
import java.util.concurrent.CountDownLatch; | ||
import java.util.concurrent.TimeUnit; | ||
import org.apache.bookkeeper.conf.ClientConfiguration; | ||
import org.apache.bookkeeper.test.BookKeeperClusterTestCase; | ||
import org.awaitility.Awaitility; | ||
import org.junit.Test; | ||
|
||
/** | ||
* Bookkeeper Client API driver metadata service available test. | ||
*/ | ||
public class DriverMetadataServiceAvailableTest extends BookKeeperClusterTestCase { | ||
|
||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. nit: we only need one blank space here. |
||
public DriverMetadataServiceAvailableTest() { | ||
super(3); | ||
} | ||
|
||
@Test | ||
public void testDriverMetadataServiceAvailable() | ||
throws Exception { | ||
ClientConfiguration conf = new ClientConfiguration(); | ||
conf.setMetadataServiceUri(zkUtil.getMetadataServiceUri()); | ||
conf.setZkTimeout(3000); | ||
try (BookKeeper bkc = BookKeeper.newBuilder(conf).build()) { | ||
Awaitility.await().until(() -> bkc.isDriverMetadataServiceAvailable().get()); | ||
zkUtil.sleepCluster(5, TimeUnit.SECONDS, new CountDownLatch(1)); | ||
Awaitility.await().until(() -> !bkc.isDriverMetadataServiceAvailable().get()); | ||
Awaitility.await().until(() -> bkc.isDriverMetadataServiceAvailable().get()); | ||
} | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nits: add blank line after