Optimize getActiveLedgersInRange

[AnonHxy]

Descriptions of the changes in this PR:

Motivation

Optimize Iterable<Long> getActiveLedgersInRange(0, Long.MAX_VALUE) by avoid applying the filter predicate when traverse the Iterable<Long>.

There are many places call getActiveLedgersInRange(0, Long.MAX_VALUE) to get the Iterable of all the ledgerId, for example:

1. bookkeeper/bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/ScanAndCompareGarbageCollector.java

   Lines 124 to 125 in 147b5bf

   	NavigableSet<Long> bkActiveLedgers = Sets.newTreeSet(ledgerStorage.getActiveLedgersInRange(0,
   	Long.MAX_VALUE));

2. bookkeeper/bookkeeper-server/src/main/java/org/apache/bookkeeper/tools/cli/commands/bookie/ConvertToDBStorageCommand.java

   Line 88 in 147b5bf

   for (long ledgerId : interleavedStorage.getActiveLedgersInRange(0, Long.MAX_VALUE)) {

3. bookkeeper/bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/storage/ldb/LocationsIndexRebuildOp.java

   Line 160 in 147b5bf

   for (Long ledger : ledgers.getActiveLedgersInRange(0, Long.MAX_VALUE)) {

We could return the keys of ledgers directly to avoid applying the filter predicate when traverse the Iterable<Long>

Changes

Return the keys of ledgers directly if firstLedgerId <=0 && lastLedgerId == Long.MAX_VALUE

[StevenLuMT]

good catch,LGTM

[horizonzy]

We would better add a new method getAllActiveLedgers.

[StevenLuMT]

We would better add a new method getAllActiveLedgers.

Whether to change the semantics of the original method, if it is changed, it is recommended to initiate a BP to add

[hangc0276]

We would better add a new method getAllActiveLedgers.

@horizonzy This change is low risk, and I think it's ok to be put in the original method.

[horizonzy]

That's fine. 

…

------------------ Original ------------------ From: Hang Chen ***@***.***> Date: Mon,Jul 3,2023 3:57 PM To: apache/bookkeeper ***@***.***> Cc: Yan Zhao ***@***.***>, Mention ***@***.***> Subject: Re: [apache/bookkeeper] Optimize getActiveLedgersInRange (PR #4005) We would better add a new method getAllActiveLedgers. @horizonzy This change is low risk, and I think it's ok to be put in the original method. — Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you were mentioned.Message ID: ***@***.***>

[horizonzy]

LGTM