Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Journal Sync wrong stats #3988

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

wenbingshen
Copy link
Member

Motivation

In Journal, we process ForceWriteRequest with batch as the smallest unit. When we rotate a Journal File, in the forceWriteRequests queue, we may contain a ForceWriteRequest of an old file, and shouldClose is true, and the last ForceWriteRequest in the queue is created by the new Jouranl file. When we batch process fwr, we only sync the last ForceWriteRequest to the disk, so that we can flash the previous fwr data of the file to the disk together. But for old files, when we process the fwr response, we will still process closeFileIfNecessary. Here we also sync the Journal files that are waiting for close, but here, we do not update JournalSyncStats.

@wenbingshen
Copy link
Member Author

rerun failure checks

2 similar comments
@wenbingshen
Copy link
Member Author

rerun failure checks

@wenbingshen
Copy link
Member Author

rerun failure checks

@wenbingshen wenbingshen reopened this Jun 23, 2023
Copy link
Member

@StevenLuMT StevenLuMT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two questions:

  1. what is the impact of the old logic?
  2. can you add a testcase to verify that the new logic to check expectations?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants