Unify ByteBufAllocator for the DirectIO component #3985
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hangc0276
requested review from
merlimat,
dlg99,
eolivelli,
zymap and
StevenLuMT
hangc0276
force-pushed
the
chenhang/unify_bytebuf_allocator
branch
from
2ce214c
to
052b80b
Compare
zymap
reviewed
Jun 16, 2023
...eper-server/src/main/java/org/apache/bookkeeper/bookie/storage/directentrylogger/Buffer.java
Outdated
Show resolved
Hide resolved
zymap
approved these changes
Jun 19, 2023
zymap
pushed a commit
that referenced
this pull request
Jun 19, 2023
### Motivation Some classes in the DirectIO component use `PooledByteBufAllocator` to create ByteBuf instead of using the BookKeeper-initiated allocator. When we configured the BookKeeper allocator OOM policy to shut down, the OOM policy can't apply to those classes which use `PooledByteBufAllocator` to create ByteBuf. ### Modifications - Unify ByteBufAllocator for the DirectIO component. (cherry picked from commit bf06642)
Ghatage
pushed a commit
to sijie/bookkeeper
that referenced
this pull request
Jul 12, 2024
### Motivation Some classes in the DirectIO component use `PooledByteBufAllocator` to create ByteBuf instead of using the BookKeeper-initiated allocator. When we configured the BookKeeper allocator OOM policy to shut down, the OOM policy can't apply to those classes which use `PooledByteBufAllocator` to create ByteBuf. ### Modifications - Unify ByteBufAllocator for the DirectIO component.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Some classes in the DirectIO component use
PooledByteBufAllocatorto create ByteBuf instead of using the BookKeeper-initiated allocator. When we configured the BookKeeper allocator OOM policy to shut down, the OOM policy can't apply to those classes which usePooledByteBufAllocatorto create ByteBuf.Modifications