Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[improve] Force Reschedule Auditor tasks #3964

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

wenbingshen
Copy link
Member

@wenbingshen wenbingshen commented May 20, 2023

Motivation

This PR follows up the comments in this PR #3945

Now when we manually trigger auditor check, we need to restart Auditor or trigger a round of auditor election to take effect.

So I hope we can trigger auditor check more smoothly. Support for Auditor Tasks rescheduling is available.

Changes

By registering the specified zk node, the callback logic of Auditor tasks rescheduling is triggered.

This PR adds the following changes:

  1. Add specified zk node for reschedule auditor tasks.
  2. The callback logic for reschedule auditor tasks.
  3. Add metric for reschedule auditor tasks.
  4. Add force flag to ForceAuditorChecksCmd to emit reschedule auditor tasks and cmd unit tests.
  5. Add Auditor tasks to be rescheduled unit tests.

BP

BP #4025
email: https://lists.apache.org/thread/w1rqy6t2jr3qrrzxjh14rjllpgw97v98

@wenbingshen wenbingshen changed the title [WIP][improve] Force ReSchedule Auditor tasks [improve] Force Reschedule Auditor tasks May 24, 2023
@wenbingshen
Copy link
Member Author

@hangc0276 @horizonzy @zymap @StevenLuMT
This PR is ready for review.
I have improved the remaining functions & add metric & add trigger cmd and unit tests & add Auditor unit tests.
PTAL. Thanks.

@wenbingshen
Copy link
Member Author

rerun failure checks

@wenbingshen
Copy link
Member Author

@hangc0276 Can we include this future in 4.16.2?

Copy link
Member

@StevenLuMT StevenLuMT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The function is still quite complicated,or add a BP to discuss?

@wenbingshen
Copy link
Member Author

The function is still quite complicated,or add a BP to discuss?

@StevenLuMT Thanks. I have started a BP to discuss it.
BP #4025
email: https://lists.apache.org/thread/w1rqy6t2jr3qrrzxjh14rjllpgw97v98

@eolivelli eolivelli modified the milestones: 4.17.0, 4.18.0 Mar 29, 2024
@dlg99
Copy link
Contributor

dlg99 commented May 30, 2024

Commented on BP: #4025 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants