Support pass threshold parameters

[gaozhangmin]

Motivation

/api/v1/bookie/gc TriggerGcService supports majorCompactionThreshold and minorCompactionThreshold majorCompactionMaxTimeMillis , minorCompactionMaxTimeMillis parameters.

Changes

/api/v1/bookie/gc TriggerGcService supports majorCompactionThreshold and minorCompactionThreshold majorCompactionMaxTimeMillis , minorCompactionMaxTimeMillis parameters.

[codecov-commenter]

Codecov Report

Merging #3778 (27c6971) into master (d6d9212) will increase coverage by 2.03%.
The diff coverage is 70.58%.

@@             Coverage Diff              @@
##             master    #3778      +/-   ##
============================================
+ Coverage     58.23%   60.27%   +2.03%     
- Complexity     5612     5818     +206     
============================================
  Files           467      473       +6     
  Lines         40822    40974     +152     
  Branches       5234     5245      +11     
============================================
+ Hits          23774    24698     +924     
+ Misses        14933    14048     -885     
- Partials       2115     2228     +113     

Flag	Coverage Δ
bookie	39.69% <11.76%> (?)
client	?
remaining	29.55% <2.94%> (+0.05%)	⬆️
replication	41.46% <67.64%> (+0.06%)	⬆️
tls	20.94% <2.94%> (-0.15%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...va/org/apache/bookkeeper/bookie/LedgerStorage.java	50.00% <ø> (+40.90%)	⬆️
...bookkeeper/bookie/storage/ldb/DbLedgerStorage.java	74.61% <0.00%> (+21.31%)	⬆️
...ie/storage/ldb/SingleDirectoryDbLedgerStorage.java	65.16% <0.00%> (+25.84%)	⬆️
...ache/bookkeeper/bookie/GarbageCollectorThread.java	77.34% <61.53%> (+21.95%)	⬆️
...okkeeper/server/http/service/TriggerGCService.java	78.43% <82.35%> (+15.57%)	⬆️
...he/bookkeeper/bookie/InterleavedLedgerStorage.java	77.81% <100.00%> (+24.06%)	⬆️
.../apache/bookkeeper/bookie/SortedLedgerStorage.java	81.15% <100.00%> (+7.24%)	⬆️
...a/org/apache/bookkeeper/client/api/BookKeeper.java	0.00% <0.00%> (-100.00%)	⬇️
.../bookkeeper/proto/checksum/DummyDigestManager.java	0.00% <0.00%> (-100.00%)	⬇️
...okkeeper/client/BookieAddressResolverDisabled.java	0.00% <0.00%> (-100.00%)	⬇️
... and 219 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[zymap]

Overall looks good to me. Could you please add a test which the request threshold is different from the configured threshold

[dlg99]

Great idea and overall lgtm.
It needs a couple of touches:

• tests for the REST API, like https://github.com/apache/bookkeeper/blob/master/bookkeeper-server/src/test/java/org/apache/bookkeeper/server/http/TestHttpService.java
• documentation update https://github.com/apache/bookkeeper/blob/master/site3/website/docs/admin/http.md

[hangc0276]

@horizonzy Please help take a look, thanks.

[StevenLuMT]

LGTM

[horizonzy]

LGTM

[gaozhangmin]

rerun failure checks

[gaozhangmin]

@hangc0276 PTAL

[gaozhangmin]

rerun failure checks

[shoothzj]

@eolivelli @hangc0276 @merlimat @nicoloboschi @zhaijack Please also take a look