Skip to content

Commit

Permalink
Fix issue with binary compatibility with older grpc versions at runti…
Browse files Browse the repository at this point in the history
…me in the bookkeeper client. (#3997)

### Motivation

- grpc version was upgraded to 1.56.0 in #3992
- that breaks binary compatibility for DnsNameResolverProvider class
  - see grpc/grpc-java@fcb5c54#diff-b04e884de51ed12ff79482f600a2d4ec18e405ee189a4952ae35f4d2742b7160L50

### Changes

- make the field type NameResolverProvider instead of DnsNameResolverProvider
  - this prevents possible NoSuchMethodError errors about DnsNameResolverProvider.newNameResolver method

(cherry picked from commit ffc8e8b)
  • Loading branch information
lhotari authored and zymap committed Jun 21, 2023
1 parent f548345 commit 7fb5e9a
Showing 1 changed file with 1 addition and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@
@Slf4j
public final class ServiceNameResolverProvider extends NameResolverFactoryProvider {

private final DnsNameResolverProvider dnsProvider;
private final NameResolverProvider dnsProvider;
private final Resource<ExecutorService> executorResource;

public ServiceNameResolverProvider() {
Expand Down

0 comments on commit 7fb5e9a

Please sign in to comment.