Skip to content

Commit

Permalink
Update Release Script Instructions and Python Publishing Scripts (#4458)
Browse files Browse the repository at this point in the history
### Motivation

This PR updates the release scripts to ensure more robust and consistent release processes. The changes include modifying the git tagging instructions to prevent potential mis-tags and updating the Python scripts to use Python 3 explicitly, which aligns with best practices for Python development.

### Changes

1. **Release Guide Modification**: Using ^{} ensures that the tag is created for the commit itself, not rc tag to be deleted.

2. **Python Publishing Script**: Changed all instances of `python` to `python3`, modern operation systems default has `python3`, but not all has `python`

Signed-off-by: ZhangJian He <[email protected]>
(cherry picked from commit 243b085)
  • Loading branch information
shoothzj committed Jul 1, 2024
1 parent 54252e2 commit 13949dd
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion site3/website/src/pages/community/release-guide.md
Original file line number Diff line number Diff line change
Expand Up @@ -476,7 +476,7 @@ Note: you can put the 1. and 2. in the same pull.
Create and push a new signed for the released version by copying the tag for the final release tag, as follows

```shell
git tag -s "${TAG}" "${RC_TAG}"
git tag -s "${TAG}" "${RC_TAG}^{}"
# Message: "Release ${VERSION}"
git push apache "${TAG}"
```
Expand Down
4 changes: 2 additions & 2 deletions stream/clients/python/scripts/publish.sh
Original file line number Diff line number Diff line change
Expand Up @@ -23,8 +23,8 @@
BINDIR=`dirname "$0"`
BK_HOME=`cd ${BINDIR}/..;pwd`

python -m pip install --user --upgrade setuptools wheel twine
python3 -m pip install --user --upgrade setuptools wheel twine

rm ${BK_HOME}/dist/*
python setup.py sdist bdist_wheel
python3 setup.py sdist bdist_wheel
twine upload dist/*

0 comments on commit 13949dd

Please sign in to comment.