AMBARI-26509 React application basic setup #4019
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
+1 |
|
@zRains Can you please help with review? |
|
+1 |
Fix licensing issues
vanshuhassija
force-pushed
the
feature/AMBARI-26509-ambari-web-react-layouting
branch
from
54542ee to
d98236d
Compare
|
@zRains @vishalsuvagia Addressed the review comments. Can you please review this again? |
|
@zRains More features will follow once this is merged. Can you please help with review? |
|
@vanshuhassija Based on previous comment, there will be a new ticket to discuss the basic project struct. I updated the ticket on Jira a few weeks ago and sent out discussion invitations, including to you, but no one responded. The new project struct conflicts with the current changes, so it hasn’t been in CR. You can share your opinions here. If there’s opposition or no feedback within a week, tick will be deprecated. This change will be in progress. |
zRains
approved these changes
Jun 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Basic React application setup with vite and Typescript. Included React Bootstrap as design system to match the look and feel of existing version. Most of the routes are defined along with some additional Design System components needed in application.
How was this patch tested?
Manual Testing