AMBARI-26311: postgresql-server should be installed even though ambari-server is configured with mysql #3945
+12
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…i-server is configured with mysql
eubnara
commented
Feb 26, 2025
Comment on lines
+114
to
+116
| properties = get_ambari_properties() | ||
| parse_properties_file(options) | ||
| options.database_index = LINUX_DBMS_KEYS_LIST.index(properties[JDBC_DATABASE_PROPERTY]) |
There was a problem hiding this comment.
Without these, it tries to execute ensure_jdbc_driver_is_installed() with postgresql even though ambari-server is configured with another RDBMS.
eubnara
commented
Feb 26, 2025
| @@ -598,6 +597,8 @@ class PGConfig(LinuxDBMSConfig): | |||
| ) | |||
|
|
|||
| def __init__(self, options, properties, storage_type): | |||
| if PGConfig.PG_INITDB_CMD is None: | |||
| raise FatalException(1, "Cannot find postgresql-setup script.") | |||
There was a problem hiding this comment.
Move FatalException here in order to raise this exception only when __init__ called with createPGConfig().
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
(Please fill in changes proposed in this fix)
Allow ambari-server can be installed or executed with db-purge-history script without postgresql-server package on centos7 if ambari-server is not configured with postgresql.
How was this patch tested?
manual tests on our company's cluster.