Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change last week to last 48 hours since weekly queries will be expensive. #48615

Closed
wants to merge 1 commit into from

Conversation

tirkarthi
Copy link
Contributor

Last week was used during development as default and got changed to last 24 hours. The last week option is expensive in large environments and might take a long time to return the results. Replace it with "last 48 hours" which is a better option.

@boring-cyborg boring-cyborg bot added the area:UI Related to UI/UX. For Frontend Developers. label Apr 1, 2025
@pierrejeambrun
Copy link
Member

Are you observing some slow requests on your big installation ? What is the bottleneck ?

@tirkarthi
Copy link
Contributor Author

I didn't run Airflow 3 as part of a large setup. We noticed slowness for these kind of aggregation queries in the legacy cluster activity page that does same aggregation for task and dagrun states over a period. I thought similar would apply here.

@pierrejeambrun
Copy link
Member

pierrejeambrun commented Apr 1, 2025

Hmmm it would be interesting to see what is actually causing the delay and optimize those queries. Here we are on the same order of magnitude (from 168 to 48, 3 times bigger install will cause the same delay, so this problem will happen again).

Maybe we should leave 1 week because that's what we want feature wise, and then observe what's limiting and optimize those ?

@jscheffl
Copy link
Contributor

jscheffl commented Apr 1, 2025

+1 to Pierre. 168h to 48h does not eliminate the root. Either the query needs to be optimized or maybe also an additional DB index is needed to speed-up.

@tirkarthi
Copy link
Contributor Author

Thanks @pierrejeambrun and @jscheffl. Closing this for now and will see if there is noticeable delay reported during RC testing and after release.

@tirkarthi tirkarthi closed this Apr 2, 2025
@tirkarthi
Copy link
Contributor Author

@vatsrahul1001 I remember some discussion on testing Airflow release in a large environment with more data. Perhaps this could be tested to ensure weekly query is fast enough in the home page.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:UI Related to UI/UX. For Frontend Developers.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants