Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove print statement added by mistake #48599

Merged
merged 1 commit into from
Mar 31, 2025

Conversation

kaxil
Copy link
Member

@kaxil kaxil commented Mar 31, 2025

I am sure this wasn't intended to be added in #48109


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in airflow-core/newsfragments.

I am sure this wasn't intended to be added in apache#48109
@kaxil kaxil requested a review from jscheffl March 31, 2025 22:43
@boring-cyborg boring-cyborg bot added the area:API Airflow's REST/HTTP API label Mar 31, 2025
Copy link
Member

@pierrejeambrun pierrejeambrun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@pierrejeambrun pierrejeambrun merged commit 71bbaeb into apache:main Mar 31, 2025
92 checks passed
@pierrejeambrun pierrejeambrun deleted the remove-print branch March 31, 2025 23:48
@jscheffl
Copy link
Contributor

jscheffl commented Apr 1, 2025

Oh nooo - thanks for fixing. Now it is revealed that I did printf() debugging :-O

@kaxil
Copy link
Member Author

kaxil commented Apr 1, 2025

Oh nooo - thanks for fixing. Now it is revealed that I did printf() debugging :-O

:D I know of no other way to debug, is there any other?

@potiuk
Copy link
Member

potiuk commented Apr 1, 2025

image

@rawwar
Copy link
Contributor

rawwar commented Apr 1, 2025

Another thing i do, is to add a helper function that opens a file and appends the text I want. This helps when there is a lot going on in the stdout

@jscheffl
Copy link
Contributor

jscheffl commented Apr 1, 2025

Was briefly checking, is there an existing pre-commit we can add preventing unwanted print() to be added to core code? :-D (Forcing to use logger for code that goes into product)

shubham-pyc pushed a commit to shubham-pyc/airflow that referenced this pull request Apr 2, 2025
I am sure this wasn't intended to be added in apache#48109
amolsr pushed a commit to amolsr/airflow that referenced this pull request Apr 2, 2025
I am sure this wasn't intended to be added in apache#48109
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:API Airflow's REST/HTTP API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants