Fix trigger dagrun deferrable mode to work with TaskSDK #48596
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gopidesupavan
requested review from
ashb,
kaxil,
amoghrajesh,
dstandish and
hussein-awala
as code owners
boring-cyborg
bot
added
area:API
|
Tests needs to be added. |
gopidesupavan
commented
Mar 31, 2025
| @@ -583,3 +584,26 @@ def context_get_outlet_events(context: Context) -> OutletEventAccessorsProtocol: | |||
| except KeyError: | |||
| outlet_events = context["outlet_events"] = OutletEventAccessors() | |||
| return outlet_events | |||
|
|
|||
|
|
|||
| def _get_dag_run_count_by_run_ids_and_states( | |||
There was a problem hiding this comment.
Not sure this is the correct place to keep this method. this method i am using inside trigger dagrun run function to get the counts.
gopidesupavan
force-pushed
the
fix-trigger-dagrun-operator
branch
from
01c2a82 to
d3ad3ce
Compare
gopidesupavan
force-pushed
the
fix-trigger-dagrun-operator
branch
from
9b164e9 to
b4acf5c
Compare
kaxil
reviewed
Apr 1, 2025
airflow-core/src/airflow/api_fastapi/execution_api/routes/dag_runs.py
Outdated
Show resolved
Hide resolved
gopidesupavan
force-pushed
the
fix-trigger-dagrun-operator
branch
from
bad8ae4 to
c0260d2
Compare
|
The test i added for dagrun in trigger its failing sometimes, it looks some flaky, i have updated test with xfile similar to 
|
1 task
gopidesupavan
force-pushed
the
fix-trigger-dagrun-operator
branch
from
f1bf9ae to
556ac60
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #47949
Adding new endpoint to get the counts for dag by run-ids and states.
Why
Airflow 3 doesn't support the direct DB access from tasks, currently
TriggerDagRunOperatordeferrable mode usesDagStateTriggerwhich access db to get the count of dag run records based on run_id's, states, logical_dates.What
Adding
/dag_runs/dag_id/countpoint to fetch the count of dag run records based on run_id's, states, logical_dates while running in triggerer.^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.