Add Task Instance clear for mapped task summaries #48584
Conversation
bbovenzi
requested review from
pierrejeambrun,
ryanahamilton and
jscheffl
as code owners
| <ActionAccordion affectedTasks={affectedTasks} note={note} setNote={setNote} /> | ||
| <ActionAccordion | ||
| affectedTasks={affectedTasks} | ||
| note={taskNote === undefined ? undefined : note} |
There was a problem hiding this comment.
I briefly thought about if it would make sense to keep the notes fied and if all are cleared then the note is applied to all mapped tasks?
But not critical / blocking. Can also be adjusted in future.
There was a problem hiding this comment.
Mark state as and setting a note are the same patch endpoint which doesn't work right now.
There was a problem hiding this comment.
If I remember correctly you need to pass a tuple somewhere.
I’ll double check tomorrow. Otherwise I think we should fix the backend
There was a problem hiding this comment.
Oh that’s the bulk patch ? Anyway I need to check the code tomorrow
There was a problem hiding this comment.
Cool. I'll hold off. It would be great to have this all at once instead of refactoring again later.
bbovenzi
force-pushed
the
allow-clearing-all-mapped-tis-at-once
branch
from
374c4fe to
662351c
Compare
On the Mapped Task Summary details page, add a Clear button to clear all the mapped tasks at once.
This PR also updated the Mark As button too, but there seems to be an API issue that prevents bulk marking state from working so the button is commented out with a TODO
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.