Move column filters button back to table header #48444
Merged
+19
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bbovenzi
requested review from
pierrejeambrun,
ryanahamilton and
jscheffl
as code owners
tirkarthi
approved these changes
Mar 28, 2025
pierrejeambrun
approved these changes
Mar 28, 2025
sunank200
pushed a commit
to astronomer/airflow
that referenced
this pull request
Mar 28, 2025
* Move column filters button back to table header * update default show
pankajkoti
pushed a commit
to astronomer/airflow
that referenced
this pull request
Mar 28, 2025
* Move column filters button back to table header * update default show
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Filter Columns button was given its own row which created a lot of excess whitespace on the page. Instead it can just be positioned at the end of the table header. Since column headers are left-aligned. We should avoid overlapping.
Also, we defaulted to always showing the column filter button. Instead, we show it if there are more than 5 columns
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.