-
Notifications
You must be signed in to change notification settings - Fork 14.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disallowing kylinpy 2.7.0 as it contains invalid pypi metadata #48226
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just wondering >2.7.0 is existing and how was it working before? Did somebody update the previously released 2.7.0 with bad meta data but it was working before?!?
See Kyligence/kylinpy#57 (comment)
Not sure if it matters. Latest version is also from 2020. It seems like there is not much to do with this SDK (also only 2 open issues there) so it might make sense that it's oldish release but probably just fine as is. |
Its actually quite coincidental, the version is a range, so it can be picked up based on other constraints, seems it is just coincidence that this version gets picked up this time! |
Well. This was not the reason in this case. The reason was really the new [aliases]
test = pytest
[metadata]
description-file = README.rst # !!!! THIS IS WRONG. Should be description_file !!!!
[egg_info]
tag_build =
tag_date = 0 The problem with There are MANY projects like There are several ways to deal with it:
So in this case - when next time setuptools maintainers will attempt to get rid of old, deprecated and "wrong" metadata packges, we either have to workaround it in one of the ways above (but then our users will have to do the same when installing airflow from |
Just to clarify - no need to revert it BTW, it will work now with setuptools 78.0.2 where they brought back handling of "invalid" metadata, but this PR would not change anything if 78.0.1 was still the latest version. |
kylinpy 2.7.0 has a bad metadata on pypi as reported here: https://github.com/apache/airflow/actions/runs/14044194114/job/39321485583
Diasllowing that version. I also wonder if we need to bump since this version was from May 2020.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rst
or{issue_number}.significant.rst
, in newsfragments.