Remove extra if condition check in publish docs job #48118
Conversation
|
We already validating condition on job level for the branch https://github.com/apache/airflow/pull/48118/files#diff-abe78e8f48c54c3cea977de0f6ad47870b0cf21522527a4b67a3aaa401c54a95R327 , so its not required to check again in steps. |
| with: | ||
| aws-access-key-id: ${{ secrets.DOCS_AWS_ACCESS_KEY_ID }} | ||
| aws-secret-access-key: ${{ secrets.DOCS_AWS_SECRET_ACCESS_KEY }} | ||
| aws-region: eu-central-1 | ||
| - name: "Upload documentation to AWS S3" | ||
| if: inputs.branch == 'main' |
There was a problem hiding this comment.
Just saw this - do you think this is a good idea? This basically means that every pipeline run will publish docs to AWS?
There was a problem hiding this comment.
Actually it wont trigger we have and condition at Job level here https://github.com/apache/airflow/pull/48118/files#diff-abe78e8f48c54c3cea977de0f6ad47870b0cf21522527a4b67a3aaa401c54a95R327. it needs canary and branch name main. so the ones removed are extra ifs. :)
There was a problem hiding this comment.
Ah, cool. Did not see this. Then all is good :-D
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.