Add Edit connection button on list connection page

[shubhamraj-git]

closes: #47497

---

^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

[jscheffl]

I noticed a few "bugs" during testing:

• Order of buttons (as other note)
• The connection ID is a writable field but same as variables can not be changed. Should get read-only I assume
• The scheme is not updated when editing. Don't know if this is a bug in the form or in the back-end but edit is just not changing scheme field
• Same with Extra fields, it can be edited but after submission the values are still the same
• Port can be changed to any text but the backend is expecting an INT. Maybe this field needs to be set to numeric to prevent users to enter text.
• I realized that the connections are always un-sorted by default - but made Order Variables, Pools and Connections lists by ID as default #48104 as separate ticket for this (as it is the same for pools and variables)

[jscheffl]

I checked the REST calls behind the form and it seems the form submits the values correctly. But it seems the REST API endpoint does not persist the changes even though reporting success. I assume there is a bug in FastAPI?

Probably in airflow-core/src/airflow/api_fastapi/core_api/routes/public/connections.py:211 it is iterating over all fields but the schema field is schema_in the pydantic model :-(

But for the extra, the "old" value is posted to the API, it seems to be reset to previous before submit.

[shubhamraj-git]

@jscheffl Yes, it seems like editing for schema and extra is not handled right via API. Payloads are going right.

I created a connection.

{
    "conn_type": "generic",
    "connection_id": "test_conn",
    "description": "this is demo",
    "extra": "{\n  \"key\": \"value\"\n}",
    "schema": "schema"
}

Now I edited it with

{
    "conn_type": "generic",
    "connection_id": "test_conn",
    "description": "this is demo - edited",
    "extra": "{\n  \"key\": \"value-edited\"\n}",
    "schema": "schema-edited"
}

But I still get

{
    "connection_id": "test_conn",
    "conn_type": "generic",
    "description": "this is demo - edited",
    "host": null,
    "login": null,
    "schema": "schema",
    "port": null,
    "password": null,
    "extra": "{\"key\": \"value\"}"
}

[jscheffl]

@jscheffl Yes, it seems like editing for schema and extra is not handled right via API. Payloads are going right.

Okay, I assume I found the root. Let me fix the API quickly.

[jscheffl]

"Fix quickly" took a bit longer. But together with #48109 fixing the backend I was able to test it and did not find any problem. With these two PRs together then connections can be edited! Wohoo!

[shubhamraj-git]

Thanks @jscheffl ! Merging this one.