Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Dag Run limit dropdown for Grid view page #47900

Merged
merged 4 commits into from
Mar 25, 2025

Conversation

shubhamraj-git
Copy link
Contributor

@shubhamraj-git shubhamraj-git commented Mar 18, 2025

Closes: #47887

image image image

^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@boring-cyborg boring-cyborg bot added the area:UI Related to UI/UX. For Frontend Developers. label Mar 18, 2025
@bbovenzi
Copy link
Contributor

bbovenzi commented Mar 18, 2025

Sorry, I'm gonna close this one. We intentionally left the dagrunselect out of the grid view because it is redundant and only adds noise to the page.

This issue wants to change the limit parameter for our useGrid() query. Not adding a dag run dropdown

@bbovenzi bbovenzi closed this Mar 18, 2025
@shubhamraj-git shubhamraj-git changed the title Add Dag Run options on Grid view page Add Dag Run limit dropdown for Grid view page Mar 19, 2025
@shubhamraj-git
Copy link
Contributor Author

@bbovenzi Oh, I see! I misread the issue. You mean having a dynamic query parameter as a dropdown, which controls the number of runs displayed, similar to how it worked in the older version.

For the older UI, I see the control was on central level, which also affects the runs list and grid view, in the new UI implementation, the State filter on the runs list tab don't affect the grid view. Are we keeping both out of sync intentionally ? In that case we will have a run count dropdown just for grid view?

I can continue the changes in this PR itself.

@shubhamraj-git shubhamraj-git force-pushed the issue-47887 branch 2 times, most recently from 5cf539d to 6f7e669 Compare March 24, 2025 18:24
@jscheffl
Copy link
Contributor

Testing I found a couple of glitches.

(1) The Grid is not displaying when I start a couple of runs. Might it be missing if some DAGs are just queued?
image
Can confirm. Might be an un-related bug. If any of the DAG runs is queued then the Grid is not displaying.

(2) Is a count is limit is seelcted, the clear button (x) is overlapping with the dropdown:
image

@bbovenzi
Copy link
Contributor

@jscheffl does that queue issue happen in main?

@shubhamraj-git
Copy link
Contributor Author

@jscheffl @bbovenzi Removed the placeholder and now it defaults to 10 and shows the same. Also removed the condition which displays it only on the grid view, since graph view have the list dag runs, which was always defaulting to 14, now instead it will be controlled via dropdown.

@jscheffl
Copy link
Contributor

@jscheffl does that queue issue happen in main?

@bbovenzi I tested yesterday on this PR... which was "close" to main. But I noticed it a couple of days ago.
But can re-produce on main. Itis simple: Navigate to a DAG with grid view. Turn scheduling of. Trigger the DAG but take care that the triogger does not activate scheduling again. See that there is a queued run. Press F5. Grid is empty.

Console reveals a HTTP 500.
Stack trace on server looks like:
image
image

Copy link
Contributor

@jscheffl jscheffl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR looks good! LGTM!

@jscheffl jscheffl merged commit 55e851b into apache:main Mar 25, 2025
34 checks passed
pankajkoti pushed a commit to astronomer/airflow that referenced this pull request Mar 28, 2025
* Add Dag Run limit dropdown for Grid view page

* Reviews
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:UI Related to UI/UX. For Frontend Developers.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing Dropdown in Grid View to Increase DAG Run Count
3 participants