-
Notifications
You must be signed in to change notification settings - Fork 14.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Dag Run limit dropdown for Grid view page #47900
Conversation
Sorry, I'm gonna close this one. We intentionally left the dagrunselect out of the grid view because it is redundant and only adds noise to the page. This issue wants to change the |
c23c373
to
4b83391
Compare
@bbovenzi Oh, I see! I misread the issue. You mean having a dynamic query parameter as a dropdown, which controls the number of runs displayed, similar to how it worked in the older version. For the older UI, I see the control was on central level, which also affects the runs list and grid view, in the new UI implementation, the State filter on the runs list tab don't affect the grid view. Are we keeping both out of sync intentionally ? In that case we will have a run count dropdown just for grid view? I can continue the changes in this PR itself. |
5cf539d
to
6f7e669
Compare
6f7e669
to
82a78db
Compare
@jscheffl does that queue issue happen in |
airflow-core/src/airflow/ui/src/layouts/Details/PanelButtons.tsx
Outdated
Show resolved
Hide resolved
@bbovenzi I tested yesterday on this PR... which was "close" to main. But I noticed it a couple of days ago. Console reveals a HTTP 500. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR looks good! LGTM!
* Add Dag Run limit dropdown for Grid view page * Reviews
Closes: #47887
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rst
or{issue_number}.significant.rst
, in newsfragments.