Fix docs build on v2-10-test branch #47820
Conversation
jscheffl
requested review from
potiuk,
ashb,
jedcunningham,
eladkal and
o-nikolas
as code owners
|
This PR is "pretty RED" but at least it fixes the docs buils and spell check in v2-10-test branch. I'd split the fixing of other stuff in another PR. |
|
Yea i think a split that fixes your issue vs everything else would be good |
1 similar comment
|
Yea i think a split that fixes your issue vs everything else would be good |
| @@ -973,7 +973,7 @@ def test_expected_output_pull_request_v2_7( | |||
| "run-tests": "true", | |||
| "docs-build": "true", | |||
| "skip-pre-commits": "check-airflow-provider-compatibility,check-extra-packages-references,check-provider-yaml-valid,identity,lint-helm-chart,mypy-airflow,mypy-dev,mypy-docs,mypy-providers,validate-operators-init", | |||
| "docs-list-as-string": "apache-airflow docker-stack", | |||
There was a problem hiding this comment.
Hmm. Are you sure this is right ?
There was a problem hiding this comment.
I am not happy about this but if the build is running with "apache-airflow docker-stack" then it seems the docsbuild catches Sphinx inventories from "current" providers and then some link breaking changes generate fails. See for example here: https://github.com/apache/airflow/actions/runs/13887634551/job/38854668394?pr=47755
Therefore to fix docs build my proposal in this PR is to build all documentation even though only core is published/needed.
But maybe I am not creative/experienced enough to understand what is broken in the docsbuild.
Docs build fails on v2.10-test branch, see https://github.com/apache/airflow/actions/runs/13875806106/job/38828565732
This bug fix is rather a bit of workaround - as a couple of doc references in providers have moved with in-compatibility to v2-10-test the cached object inventories which are used normally are in-compatible. As providers are not maintained on the maintenance branch... the workaround is to build just all docs (with the trade-off of a bit longer build time... but we do not build too often on maintenance branch...) and "tweak" the outdated provider docs to have no errors.
Other ideas welcome as well. But with this the core docs are now building again.