Bugfix/fix disk space issues in GitHub #47816
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Triage disk space issues, DO NOT MERGE * Triage disk space issues, DO NOT MERGE * Triage disk space issues, DO NOT MERGE * Triage disk space issues, DO NOT MERGE * Triage disk space issues, DO NOT MERGE * Triage disk space issues, DO NOT MERGE * Triage disk space issues, DO NOT MERGE * Move docker storage to second drive in general * Cleanup debug and triaging stuff * Exception of docker volume for constraints building
…e#46428) The apache#46358 moved docker to another mounted directory - but this directory and all files in it are owned by host user. The directory and all files inside should be owned by root in order to properly reflect permissions of the files when building docker images. The change is now simplified. Rather than passing mount directory by variable and passing it through GitHub Actions, we hard-code the location of docker in cleanup_docker.sh script - we also incorporate changing ownership and showing disk space in the same cleanup_docker.sh script and make sure that script is only called in the "real" (not composite) actions at the beginning - right after the repository is checked out - previously that script was also called in composite actions and changing the repo to be writeable was done AFTER cleanup_docker.sh - which would not work as we want the /mnt directory to be still owned by the host user, but the docker storage should be still owned by root.
potiuk
approved these changes
Mar 15, 2025
|
Failures are unrelated to the fix, merging. |
|
cool seems v2 will be happy now :) |
No, unfortunately some further fixes needed.... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As we see disk space issues in v2-10-test builds... cherry-pick #46358 and #46428 to the maintenance branch,