Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix static checks in v2-10-test branch #47803

Merged
merged 1 commit into from
Mar 15, 2025

Conversation

jscheffl
Copy link
Contributor

I saw that static checks fail (amoungst others) in v2-10-test PRs. I'll attempt to fix this.

This is the first PR that fixes static checks. Mainly by disabling / excluding provider sources from mypy. Providers are validated against old Airflow versions in main CI anyway.

@jscheffl
Copy link
Contributor Author

@bugraoz93 Oh, committer status is not live in Github :-O
image

@bugraoz93
Copy link
Contributor

@bugraoz93 Oh, committer status is not live in Github :-O image

Seems like that's the case. Looking forward to seeing the green one :D I think still a couple of PR needed but not sure they are dependent on other things 🤔

@gopidesupavan
Copy link
Member

@bugraoz93 Oh, committer status is not live in Github :-O image

Seems like that's the case. Looking forward to seeing the green one :D I think still a couple of PR needed but not sure they are dependent on other things 🤔

I think you need to sync GitHub id with ASF

@bugraoz93
Copy link
Contributor

@bugraoz93 Oh, committer status is not live in Github :-O image

Seems like that's the case. Looking forward to seeing the green one :D I think still a couple of PR needed but not sure they are dependent on other things 🤔

I think you need to sync GitHub id with ASF

Aah, that will take time. Great info! 🙏

@jscheffl
Copy link
Contributor Author

Merging. Static checks look better, will raise another PR for other fails.

@jscheffl jscheffl merged commit e187438 into apache:v2-10-test Mar 15, 2025
53 of 59 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants