Fix using Edge Worker in Breeze due to rolling random secret #47754
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jscheffl
force-pushed
the
bugfix/edge-worker-fail-in-breeze
branch
from
554b829 to
be9c737
Compare
eladkal
approved these changes
Mar 14, 2025
agupta01
pushed a commit
to agupta01/airflow
that referenced
this pull request
Mar 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #46966 it was adjusted to randomize secrets if not configured - which is a good thing!
Unfortunately in breeze the secrets are undefined, whcih causes each call to random generate new secrets... meaning that different running components use different random keys - with every call.
Before this PR attempt using
airflow config list|grep secret_keyand you see with each call new secrets.This casued EdgeWorker to fail to start in Breeze ans the secret keys were randomized.
This PR also randomize generate secrets but sets this in the ENV for each start of breeze.