Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add service endpoint to provide hook meta data for UI #47588

Merged

Conversation

jscheffl
Copy link
Contributor

@jscheffl jscheffl commented Mar 10, 2025

Based on PoC in #41656 this PR adds a service endpoint to service to describe hook meta data such that the UI can be rendered. It is based on the information provided in Airflow 2.0 and allows field hiding, re-labelling and placeholder texts for common fields. Also it provides extra fields which are persisted as JSON. The provided extra fields are compatible with the param struct model from the DAG details such that the FlexibleForm rendering can be re-used as component.

FYI @shubhamraj-git as you might want to start adding UI on it?

relates: #47502
closes: #47501

@boring-cyborg boring-cyborg bot added area:API Airflow's REST/HTTP API area:UI Related to UI/UX. For Frontend Developers. labels Mar 10, 2025
Copy link
Contributor

@shubhamraj-git shubhamraj-git left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Jens, Some minor nits.

@jscheffl jscheffl force-pushed the feature/47502-add-service-for-hook-meta-data branch from 4ea937b to 3683641 Compare March 11, 2025 22:32
@jscheffl jscheffl marked this pull request as ready for review March 11, 2025 22:45
@jscheffl jscheffl requested a review from shubhamraj-git March 11, 2025 22:45
Copy link
Contributor

@bbovenzi bbovenzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generated types look good to me

@jscheffl jscheffl force-pushed the feature/47502-add-service-for-hook-meta-data branch from 2f17e4c to ef92550 Compare March 12, 2025 20:44
@jscheffl jscheffl merged commit 3539190 into apache:main Mar 12, 2025
89 checks passed
agupta01 pushed a commit to agupta01/airflow that referenced this pull request Mar 13, 2025
* Add service endpoint to provide hook meta data for UI

* Review Feedback

* Add pytest, re-wire ui connection endpoint

* Re-naming class feedback

* Revert import formatting change

* Make test as DB test for FAB auth
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:API Airflow's REST/HTTP API area:UI Related to UI/UX. For Frontend Developers.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AIP-38 | Add API Endpoint to serve connection types and extra form meta data
3 participants