-
Notifications
You must be signed in to change notification settings - Fork 14.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add service endpoint to provide hook meta data for UI #47588
Merged
jscheffl
merged 6 commits into
apache:main
from
jscheffl:feature/47502-add-service-for-hook-meta-data
Mar 12, 2025
Merged
Add service endpoint to provide hook meta data for UI #47588
jscheffl
merged 6 commits into
apache:main
from
jscheffl:feature/47502-add-service-for-hook-meta-data
Mar 12, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Jens, Some minor nits.
4ea937b
to
3683641
Compare
bbovenzi
approved these changes
Mar 12, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generated types look good to me
2f17e4c
to
ef92550
Compare
agupta01
pushed a commit
to agupta01/airflow
that referenced
this pull request
Mar 13, 2025
* Add service endpoint to provide hook meta data for UI * Review Feedback * Add pytest, re-wire ui connection endpoint * Re-naming class feedback * Revert import formatting change * Make test as DB test for FAB auth
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on PoC in #41656 this PR adds a service endpoint to service to describe hook meta data such that the UI can be rendered. It is based on the information provided in Airflow 2.0 and allows field hiding, re-labelling and placeholder texts for common fields. Also it provides extra fields which are persisted as JSON. The provided extra fields are compatible with the param struct model from the DAG details such that the FlexibleForm rendering can be re-used as component.
FYI @shubhamraj-git as you might want to start adding UI on it?
relates: #47502
closes: #47501