Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup leftovers from api connexion #47490

Merged
merged 6 commits into from
Mar 7, 2025
Merged

Cleanup leftovers from api connexion #47490

merged 6 commits into from
Mar 7, 2025

Conversation

jscheffl
Copy link
Contributor

@jscheffl jscheffl commented Mar 7, 2025

As #47171 was the general removal of api_connexion, this PR here attempts to clean all leftovers in the codebase towards connexion.

Will iterate on a DRAFT first, please wait for review until green

@jscheffl jscheffl mentioned this pull request Mar 7, 2025
Merged
@jscheffl jscheffl added full tests needed We need to run full set of tests for this PR to merge all versions If set, the CI build will be forced to use all versions of Python/K8S/DBs labels Mar 7, 2025
@jscheffl jscheffl changed the title Feature/cleanup leftovers from api connexion Cleanup leftovers from api connexion Mar 7, 2025
@jscheffl jscheffl force-pushed the feature/cleanup-leftovers-from-api-connexion branch from 64d0dd3 to 95191c6 Compare March 7, 2025 13:28
vincbeck
vincbeck approved these changes Mar 7, 2025
View reviewed changes
Copy link
Contributor

@vincbeck vincbeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good! Some tests need to be fixed (but it should be straightforward) and some conflicts as well

@jscheffl jscheffl force-pushed the feature/cleanup-leftovers-from-api-connexion branch from c20692d to 2dab26c Compare March 7, 2025 17:04
@jscheffl jscheffl marked this pull request as ready for review March 7, 2025 17:04
@jscheffl jscheffl force-pushed the feature/cleanup-leftovers-from-api-connexion branch from 2dab26c to d99fad9 Compare March 7, 2025 17:05
@jscheffl jscheffl merged commit 7bd8ea6 into apache:main Mar 7, 2025
148 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@potiuk potiuk potiuk approved these changes

@bugraoz93 bugraoz93 bugraoz93 approved these changes

@vincbeck vincbeck vincbeck approved these changes

@kaxil kaxil Awaiting requested review from kaxil kaxil is a code owner

@pierrejeambrun pierrejeambrun Awaiting requested review from pierrejeambrun pierrejeambrun is a code owner

@ashb ashb Awaiting requested review from ashb ashb is a code owner

@jedcunningham jedcunningham Awaiting requested review from jedcunningham jedcunningham is a code owner

Assignees
No one assigned
Labels
all versions If set, the CI build will be forced to use all versions of Python/K8S/DBs area:CLI area:dev-tools full tests needed We need to run full set of tests for this PR to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jscheffl @potiuk @bugraoz93 @vincbeck