Add other executor tests to K8s tests #47472
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
As discussed #46502 was accidentally removing the other tests in Feb 😓 .. |
|
We should bring back all tests. |
|
There are also KPO tests for example. |
|
cc: @jason810496 -> Maybe you can bring it back, apparently I missed that #46502 only run k8S test. |
|
As #46502 was made to remove flakiness... hopefully this does not add it back again :-O |
|
👀 |
|
I accidentally committed the modified test case (I only ran the KubernetesExecutor locally for faster iteration during development). I believe this won’t reintroduce flakiness, as I simply replaced time.sleep with kubectl rollout status --watch. |
jscheffl
force-pushed
the
bugfix/add-k8s-tests-in-breeze-for-other-executors
branch
2 times, most recently
from
da1deaa to
cbc4fa4
Compare
1 task
jscheffl
force-pushed
the
bugfix/add-k8s-tests-in-breeze-for-other-executors
branch
from
cbc4fa4 to
28aeeb0
Compare
|
Green (besides sadly I needed to add XFail for the LocalExecutor tests which are caused by not able to make LocalExecutor work in KinD --> #47518 ) |
potiuk
approved these changes
Mar 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Somehow ONLY k8sExecutor used pytests in K8s CI deployments. @potiuk pointed me to the fact that other executors also had tests... but seems they were not called.
This PR (attempts) to add the tests for other executors