Rework Params UI Tutorial DAG #47265
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jscheffl
force-pushed
the
feature/rework-params-ui-tutorial-dag
branch
from
f175332 to
cfd5e91
Compare
There was a problem hiding this comment.
PR Overview
This PR refactors the Params UI Tutorial DAG to improve the form UI by consolidating parameters and organizing them into clearer sections.
- Renames parameter keys to be more descriptive (e.g. changing "x" to "number_param").
- Adds section attributes to group parameters by type and functionality.
- Introduces additional parameters (boolean, date/time, required/optional text fields) to broaden form functionality.
Reviewed Changes
| File | Description |
|---|---|
| airflow/example_dags/example_params_ui_tutorial.py | Parameter keys are renamed and reorganized into sections to improve UI clarity and form usability. |
Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.
Comments suppressed due to low confidence (2)
airflow/example_dags/example_params_ui_tutorial.py:83
- Consider renaming the parameter key 'bool' to a more descriptive name (e.g., 'confirm_param') to avoid confusion with Python's built-in bool type.
"bool": Param(
airflow/example_dags/example_params_ui_tutorial.py:207
- [nitpick] Consider renaming the section to a more concise and standard title, such as 'Advanced Form Fields', for clarity.
section="Special advanced stuff with form fields",
eladkal
reviewed
Mar 2, 2025
jscheffl
force-pushed
the
feature/rework-params-ui-tutorial-dag
branch
from
006dcf0 to
75e7813
Compare
jscheffl
force-pushed
the
feature/rework-params-ui-tutorial-dag
branch
from
3753b5e to
740b051
Compare
Co-authored-by: Copilot <[email protected]>
jscheffl
force-pushed
the
feature/rework-params-ui-tutorial-dag
branch
from
740b051 to
7ccf877
Compare
|
@eladkal can you re-review? Or shall I ask somebody else? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that the Params UI Tutorial DAG had quite a lengthy list of parameters... and as the new trigger form is a modal it was hard to see all values.
I consolidated a few fields and added more form sections to make the view better.
FYI @shubhamraj-git