Skip to content

Conversation

@aritra24
Copy link
Collaborator

@aritra24 aritra24 commented Mar 1, 2025

The backfill button not being a child
has the menu button's click propagate
down leading to the modal auto closing.


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

The backfill button not being a child
has the menu button's click propagate
down leading to the modal auto closing.
@boring-cyborg boring-cyborg bot added the area:UI Related to UI/UX. For Frontend Developers. label Mar 1, 2025
@aritra24
Copy link
Collaborator Author

aritra24 commented Mar 1, 2025

I'm not entirely sure if this is the right approach to fixing this, so would definitely welcome some comments. Took quite a while to find the cause and my guess is it's because when the menu button's child item is clicked it triggers an auto close which is propagated down to it's children? Which in turn causes the modal's onClose to be called? Atleast that's my educated guess.

@enchant3dmango
Copy link
Contributor

@aritra24 since it's a UI change, I think it's better if you can provide the screenshot of the before and after changes applied.

@aritra24
Copy link
Collaborator Author

aritra24 commented Mar 1, 2025

Unfortunately not much of a screenshot to provide here, since the bug was the dialog box was flashing before now it doesn't.

@jscheffl
Copy link
Contributor

jscheffl commented Mar 1, 2025

Thanks for the fix - I was also noticing it is broken when I implemented #47250

Not being an expert in UI stuff, I assume this really fixes it.

@jscheffl jscheffl merged commit 51c2590 into apache:main Mar 1, 2025
35 checks passed
@aritra24 aritra24 deleted the bug_backfill branch March 1, 2025 17:18
shahar1 pushed a commit to shahar1/airflow that referenced this pull request Mar 5, 2025
The backfill button not being a child
has the menu button's click propagate
down leading to the modal auto closing.
nailo2c pushed a commit to nailo2c/airflow that referenced this pull request Apr 4, 2025
The backfill button not being a child
has the menu button's click propagate
down leading to the modal auto closing.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:UI Related to UI/UX. For Frontend Developers.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants