Respect celery log level in structlog config / try to clean up a bit #46999
+133
−134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This area of code is quite confusing and hard to follow. I try to make it a *little* bit easier to follow by breaking up some of the functions into smaller ones. In some cases this clarifies the logic a little bit. I did not intend any behavior changes in the refactor portion of this. The one behavior change I did intend was in the celery_command file, where I pass the log level to `configure_logging` so that you don't have debug logs on by default when using structlog. There's a lot here that I still don't really understand and which remains confusing but I accomplished my main goal here so moving on for now.
dstandish
requested review from
ashb and
amoghrajesh
and removed request for
hussein-awala
| if AIRFLOW_V_3_0_PLUS: | ||
| from airflow.sdk.log import configure_logging | ||
|
|
||
| configure_logging(output=sys.stdout.buffer) | ||
| configure_logging(output=sys.stdout.buffer, log_level=celery_log_level) |
There was a problem hiding this comment.
Hmm, celery_log_level used to just change the logging level in celery itself, right? Does this impact the Airflow side now too?
|
|
||
|
|
||
| @cache | ||
| def logging_processors_ugly(): |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This area of code is quite confusing and hard to follow. I try to make it a little bit easier to follow by breaking up some of the functions into smaller ones. In some cases this clarifies the logic a little bit. I did not intend any behavior changes in the refactor portion of this.
The one behavior change I did intend was in the celery_command file, where I pass the log level to
configure_loggingso that you don't have debug logs on by default when using structlog.There's a lot here that I still don't really understand and which remains confusing but I accomplished my main goal here so moving on for now.