Add requires_result_fetch Configuration to SQLExecuteQueryOperator #46997
+3
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EdenKik
changed the title
nevcohen
reviewed
Feb 23, 2025
| @@ -253,6 +253,7 @@ def __init__( | |||
| split_statements: bool | None = None, | |||
| return_last: bool = True, | |||
| show_return_value_in_logs: bool = False, | |||
| requires_result_fetch: bool = False, | |||
There was a problem hiding this comment.
Add this also to class init doc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a new configuration option within SQLExecuteQueryOperator: requires_output_processing.
When True, the operator ensures that query results are fetched, preventing premature cancellations (required for Trino and similar engines).
When False, it behaves as before, skipping result processing if not needed.
closes: #46808
related: #46808