Add MwaaDagRunSensor to Amazon Provider Package #46945
Open
+228
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Includes the doc page, unit tests and system test. Support for deferrable mode will be added soon.
ramitkataria
force-pushed
the
ramitkataria/mwaa-dag-sensor
branch
from
4a59f3e to
6a9b286
Compare
…erministic so that xdist execution doesn't fail
|
Added reviewers at Ramit's request. |
o-nikolas
approved these changes
Feb 22, 2025
Comment on lines
+44
to
+45
| s_states = {"state1", "state2"} | ||
| f_states = {"state3", "state4"} |
There was a problem hiding this comment.
minor nit: But I don't love single character variable names (or even components of a variable name with single characters). I think it's much cleaner an readable to have success_states and failure_states and it's really not thaaat much longer.
| assert sensor.ext_env_name == SENSOR_KWARGS["external_env_name"] | ||
| assert sensor.ext_dag_id == SENSOR_KWARGS["external_dag_id"] | ||
| assert sensor.ext_dag_run_id == SENSOR_KWARGS["external_dag_run_id"] | ||
| assert set(sensor.success_states) == set(s_states) |
There was a problem hiding this comment.
nit: Does the left side need the coercion to set? Don't you already do that inside the sensor init? And the s_states is already a set too?
Comment on lines
+53
to
+55
| with pytest.raises(AirflowException): | ||
| MwaaDagRunSensor( | ||
| **SENSOR_KWARGS, success_states={"state1", "state2"}, failure_states={"state2", "state3"} |
There was a problem hiding this comment.
nit: This feels like a sad case tacked onto the end of a happy path unit test. Maybe split it out into it's own?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes the doc page, unit tests and system test
Support for deferrable mode will be added soon (in another PR)
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.