-
Notifications
You must be signed in to change notification settings - Fork 14.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove old UI and webserver #46942
base: main
Are you sure you want to change the base?
Remove old UI and webserver #46942
Conversation
This will need to be adjusted again when we have UIAlert support in AF3, but this will do for now :)
So we don't loose it from the original PR: #protm! |
THis will probably have a blast radius?
Now we removed www, FAB is not automatically set up for tests. This is causing problems in FAG provider tests. |
I'm starrting to take a look into failing breeze tests... |
…manager/test_aws_security_manager_override.py`
I did too @jscheffl -> fixed some more |
I was unsure and wated to contact you.... but you fixed what I suspected and wondered why this was the impact. |
fab provider is added as amazon's optional dependency -> that triggers the tests transitively |
I was attempting to make some fixes to the pytests failing, but I am missing an idea how the previous mocked |
I think it's a matter of adding the right fixture to |
@pierrejeambrun @bbovenzi take a look at 6a01eaa - I didn't want to tackle a general "build arbitrary url" helper, so I just did dagrun. Is there something existing for this use case though? |
Try to strip out as much of the old webserver and UI as possible for AIP-79.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rst
or{issue_number}.significant.rst
, in newsfragments.