Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove old UI and webserver #46942

Open
wants to merge 31 commits into
base: main
Choose a base branch
from
Open

Remove old UI and webserver #46942

wants to merge 31 commits into from

Conversation

bbovenzi
Copy link
Contributor

excited-fuego

Try to strip out as much of the old webserver and UI as possible for AIP-79.


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@jedcunningham
Copy link
Member

So we don't loose it from the original PR: #protm!

@Lee-W Lee-W self-requested a review February 21, 2025 03:15
@uranusjr
Copy link
Member

Now we removed www, FAB is not automatically set up for tests. This is causing problems in FAG provider tests.

@jscheffl
Copy link
Contributor

I'm starrting to take a look into failing breeze tests...

@potiuk
Copy link
Member

potiuk commented Feb 21, 2025

I did too @jscheffl -> fixed some more

@jscheffl
Copy link
Contributor

I did too @jscheffl -> fixed some more

I was unsure and wated to contact you.... but you fixed what I suspected and wondered why this was the impact.

@potiuk
Copy link
Member

potiuk commented Feb 21, 2025

I was unsure and wated to contact you.... but you fixed what I suspected and wondered why this was the impact.

fab provider is added as amazon's optional dependency -> that triggers the tests transitively

@jscheffl
Copy link
Contributor

I was attempting to make some fixes to the pytests failing, but I am missing an idea how the previous mocked app based on appbuilder+Flask can be replicated over. I fear either we need to re-write a lot of tests or we need to add the dependency to FAB provider... which is also not helpful.
A common solution would be great but I am lagging an idea.

@potiuk
Copy link
Member

potiuk commented Feb 23, 2025

I was attempting to make some fixes to the pytests failing, but I am missing an idea how the previous mocked app based on appbuilder+Flask can be replicated over. I fear either we need to re-write a lot of tests or we need to add the dependency to FAB provider... which is also not helpful.
A common solution would be great but I am lagging an idea.

I think it's a matter of adding the right fixture to tests_common so that it can be used with those tests - following the new "fast_api" way of initializing the app, but I also lack a bit of understanding how it is done now without doing a lot of digging

@jedcunningham
Copy link
Member

@pierrejeambrun @bbovenzi take a look at 6a01eaa - I didn't want to tackle a general "build arbitrary url" helper, so I just did dagrun. Is there something existing for this use case though?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:CLI area:dev-tools area:UI Related to UI/UX. For Frontend Developers. area:webserver Webserver related Issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants