Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Asset Decorator to Use SdkDAG for Improved Modularity (#46927) #46936

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

shashbha14
Copy link

This PR introduces SdkDAG inside the SDK to replace the direct dependency on airflow.models.dag within the asset decorator. This improves modularity and aligns with the project’s architectural principles.

Changes:
Implemented SdkDAG within airflow.sdk.dag.
Updated asset decorators (@asset and @asset.multi) to use SdkDAG instead of airflow.models.dag.
Ensured compatibility with existing asset definitions.
Why This Change?
Addresses Issue #46927.
Provides a structured way to define DAGs within the SDK.
Improves maintainability by reducing dependencies on core Airflow modules.
Next Steps:
Run full test suite to validate the changes.
Gather feedback from maintainers for further refinements.

Copy link

boring-cyborg bot commented Feb 20, 2025

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
Here are some useful points:

  • Pay attention to the quality of your code (ruff, mypy and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
  • Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: [email protected]
    Slack: https://s.apache.org/airflow-slack

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant