Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

List Pools under the admin nav button #45587

Merged
merged 7 commits into from
Jan 21, 2025
Merged

Conversation

shubhamraj-git
Copy link
Contributor

@shubhamraj-git shubhamraj-git commented Jan 12, 2025

Pools option:
Screenshot 2025-01-12 at 4 01 30 PM

Deferred flag status:
Screenshot 2025-01-12 at 4 36 30 PM

Different slots:
Screenshot 2025-01-12 at 4 36 36 PM

related: #43706


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@boring-cyborg boring-cyborg bot added the area:UI Related to UI/UX. For Frontend Developers. label Jan 12, 2025
@shubhamraj-git
Copy link
Contributor Author

I have currently utilised the Run status colour which closely aligns with the pool slot options. Reason to that is, run status colours are used all over the UI from a single source of truth(airflow/ui/src/utils/stateColor.ts). Just to not confuse users I kept the same colours of that.

The stateColor currently used are:

export const stateColor = {
  deferred: "mediumpurple",
  failed: "red",
  null: "lightblue",
  queued: "gray",
  removed: "lightgrey",
  restarting: "violet",
  running: "lime",
  scheduled: "tan",
  skipped: "hotpink",
  success: "green",
  up_for_reschedule: "turquoise",
  up_for_retry: "gold",
  upstream_failed: "orange",
};

One advantage of this would be when users will personalise the status colours of runs (https://airflow.apache.org/docs/apache-airflow/1.10.13/howto/customize-state-colors-ui.html) these values will also change.

If we should have a fixed colour, we can use the below options: (Open to discussion)

Open Slots	     Green
Scheduled Slots	     Gray	
Running Slots	     Blue	
Queued Slots	     Orange
Occupied Slots	     Yellow	
Deferred Slots	     Red	

Which would look like
Screenshot 2025-01-12 at 4 01 20 PM

Copy link
Contributor

@bbovenzi bbovenzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! Left a few comments.

I would also like to play with adding an icon to each pool slot so it can be more accessible vs just via color. Doesn't have to be this PR, I just wanted to put the idea out there.

@shubhamraj-git
Copy link
Contributor Author

@bbovenzi Also, regarding slots icons, let me think of something, will try something COOL in upcoming PRs!

@jscheffl jscheffl merged commit dbf5c49 into apache:main Jan 21, 2025
35 checks passed
@utkarsharma2 utkarsharma2 added the type:new-feature Changelog: New Features label Jan 27, 2025
@utkarsharma2 utkarsharma2 added this to the Airflow 3.0.0 milestone Jan 27, 2025
gpathak128 pushed a commit to gpathak128/airflow that referenced this pull request Jan 29, 2025
* add list pools

* utilise the state colors

* reviews

* icon

* remove condition

* disable lint rules
got686-yandex pushed a commit to got686-yandex/airflow that referenced this pull request Jan 30, 2025
* add list pools

* utilise the state colors

* reviews

* icon

* remove condition

* disable lint rules
niklasr22 pushed a commit to niklasr22/airflow that referenced this pull request Feb 8, 2025
* add list pools

* utilise the state colors

* reviews

* icon

* remove condition

* disable lint rules
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:UI Related to UI/UX. For Frontend Developers. type:new-feature Changelog: New Features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants