-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to Node 20 and add outputs #1
base: master
Are you sure you want to change the base?
Conversation
@jgillick thanks for submit PR - I will review and come to you with update. BTW. sorry for so late response 🙏🏻 |
Github is now deprecating node16 and using node20 |
I've updated the PR to node20 and removed the automatic formatting my IDE applied to |
If anybody else want to use this before the PR is merged, you can update your YML files to use |
found-artifact
:boolean
path
:string
ncc
to bundle the script and dependencies into a single JS file (dist/index/js
), so thatnode_modules
doesn't need to be committed to github.Now, every time
main.js
is updated, you'll need to runnpm script build
to generate the compiled script. If you prefer bundlingnode_modules
, we can revert this change. However, committingnode_modules
makes PRs pretty messy because they'll include every file that changed in all of the modules.