Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Node 20 and add outputs #1

Open
wants to merge 12 commits into
base: master
Choose a base branch
from

Conversation

jgillick
Copy link

@jgillick jgillick commented Oct 18, 2022

  • Github Actions is deprecating Node 12.
  • Added the following outputs:
    • found-artifact: boolean
    • path : string
  • Used ncc to bundle the script and dependencies into a single JS file (dist/index/js), so that node_modules doesn't need to be committed to github.

Now, every time main.js is updated, you'll need to run npm script build to generate the compiled script. If you prefer bundling node_modules, we can revert this change. However, committing node_modules makes PRs pretty messy because they'll include every file that changed in all of the modules.

@aochmann aochmann self-requested a review April 7, 2023 12:53
@aochmann
Copy link
Owner

aochmann commented Apr 7, 2023

@jgillick thanks for submit PR - I will review and come to you with update. BTW. sorry for so late response 🙏🏻

@ardittristan
Copy link

Github is now deprecating node16 and using node20

@jgillick jgillick changed the title Upgrade to Node 16 and add outputs Upgrade to Node ~16~ 20 and add outputs Mar 5, 2024
@jgillick jgillick changed the title Upgrade to Node ~16~ 20 and add outputs Upgrade to Node 20 and add outputs Mar 5, 2024
@jgillick
Copy link
Author

jgillick commented Mar 5, 2024

I've updated the PR to node20 and removed the automatic formatting my IDE applied to main.js. I also updated the PR description explaining why node_modules has been removed.

@jgillick
Copy link
Author

jgillick commented Mar 5, 2024

If anybody else want to use this before the PR is merged, you can update your YML files to use jgillick/actions-download-artifact@master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants