-
Notifications
You must be signed in to change notification settings - Fork 5
Add new functionality #275
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @anushkavidanage.
@@ -51,6 +51,7 @@ import 'package:solidpod/src/solid/utils/misc.dart'; | |||
/// representing the result of the operation. | |||
Future<String> setPermissionAcl( | |||
String resourceUrl, | |||
String ownerWebId, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For methods that now take ownerWebID
and removerWebId
as required positional parameters:
- Will callers that still use the old signatures fail to compile?
- Could we potentially make these new parameters optional named arguments (with sensible defaults) to preserve source compatibility?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Ashley, this, unfortunately, cannot be made optional. The old function did not have the functionality to set permission when the permission giver and the owner are two different people. So adding that functionality means we have to stop using the old version.
Pull Request Details
What issue does this PR address
Add extra functionality to solidpod package. To see all added functionality check the issue SOLID POD: Add extra functionality related to managing external POD resources #274
Link to associated issue: SOLID POD: Add extra functionality related to managing external POD resources #274
Noe: To check this PR, please use Av/113 migrate to solidpod notepod#117
Checklist
Complete the check-list below to ensure your branch is ready for PR.
Flutter Style Guide: https://survivor.togaware.com/gnulinux/flutter-style.html
make prep
orflutter analyze lib
)Finalising
Once PR discussion is complete and 2 reviewers have approved: