Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

typos #377

Merged
merged 3 commits into from
Nov 23, 2023
Merged

typos #377

merged 3 commits into from
Nov 23, 2023

Conversation

a-detiste
Copy link
Contributor

typo found by Debian's lintian

these files are not executables...
Copy link
Contributor

@DDR0 DDR0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small but solid changes. 👌

@DDR0 DDR0 enabled auto-merge November 20, 2023 18:31
@DDR0
Copy link
Contributor

DDR0 commented Nov 20, 2023

Thank you for the tidying up, @a-detiste. o7

@DDR0 DDR0 disabled auto-merge November 21, 2023 04:08
@DDR0 DDR0 enabled auto-merge November 21, 2023 04:09
@Rotonen
Copy link
Contributor

Rotonen commented Nov 21, 2023

I've discovered a fault in my CI setup with regards to builds from forks: turns out only pull_request triggers from forks can fire, not push triggers.

https://docs.github.com/en/actions/managing-workflow-runs/approving-workflow-runs-from-public-forks
https://docs.github.com/en/actions/using-workflows/events-that-trigger-workflows#pull-request-events-for-forked-repositories

This now needs to go first: #380

And then one can simply click the "update branch" button on this branch and reapprove and the automerge and merge queue machinery will take care of the rest.

Sorry for the inconvenience.

@a-detiste
Copy link
Contributor Author

I plan to package this for Debian at the event that's happening end of this week in Cambridge. (FWIW) then we can update Frogatto.

@Rotonen
Copy link
Contributor

Rotonen commented Nov 21, 2023

Please coordinate all things Debian with Martin Quinson as he seems to be the currently active uploader for the frogatto package.

@a-detiste
Copy link
Contributor Author

a-detiste commented Nov 21, 2023

I never received the message that is publicly archived here: https://bugs.debian.org/1055343

I know now it's being handled, thanks for the tip.

@DDR0 DDR0 added this pull request to the merge queue Nov 23, 2023
Merged via the queue into anura-engine:trunk with commit 6a52902 Nov 23, 2023
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants