Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support building on newer JDKs #14

Merged
merged 6 commits into from
Aug 3, 2023

Conversation

l0s
Copy link
Contributor

@l0s l0s commented Oct 4, 2020

This updates the CI configuration to build using JDKs 8, 10, and 11. Locally, I tested using 8, 9, 10, 12, and 14. The build issues were resolved by upgrading test and plugin dependencies and making minor code changes.

Resolves: #13

This updates the CI configuration to build using JDKs 8, 10, and 11.
Locally, I tested using 8, 9, 10, 12, and 14. The build issues were
resolved by upgrading test and plugin dependencies and making minor code
changes.

Resolves: antkorwin#13
@codecov-commenter
Copy link

codecov-commenter commented Oct 4, 2020

Codecov Report

Merging #14 (0983e08) into master (437d4d3) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master      #14   +/-   ##
=========================================
  Coverage     99.16%   99.16%           
  Complexity       37       37           
=========================================
  Files             4        4           
  Lines           120      120           
  Branches         10       10           
=========================================
  Hits            119      119           
  Partials          1        1           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@l0s
Copy link
Contributor Author

l0s commented Oct 4, 2020

The CI server failures were also encountered and fixed in scope of #12 . I can port those changes here if desired.

@sonarcloud
Copy link

sonarcloud bot commented May 1, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@RavenVSS
Copy link
Collaborator

RavenVSS commented Jun 2, 2023

Hi, @l0s
Please resolve conflicts.

l0s added 5 commits June 3, 2023 23:23
This updates the CI configuration to build using JDKs 8, 10, and 11.
Locally, I tested using 8, 9, 10, 12, and 14. The build issues were
resolved by upgrading test and plugin dependencies and making minor code
changes.

Resolves: antkorwin#13
Add version matrix to GitHub actions and fix test compilation error.

Resolves: antkorwin#13
Fix build error on JDK 17

Resolves: antkorwin#13
Delete file that was removed upstream

Resolves: antkorwin#13
@l0s
Copy link
Contributor Author

l0s commented Jun 4, 2023

@RavenVSS, I resolved the merge conflicts. I also moved the build configuration from Travis to GitHub Actions and used the current list of supported JDK versions.

Two of the checks are failing. The SonarCloud check appears to be a configuration error and is also failing on master. The other requires certain labels on the PR, which will need to be added by a project maintainer.

@RavenVSS RavenVSS merged commit 6e46fbf into antkorwin:master Aug 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support building with JDK 10 and 11
3 participants