Add StampedLockFactory and ReadWriteLockFactory #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds two new factories that generate `StampedLock` and `ReadWriteLock` instances for applications that require more granular control over locking. The unit tests duplicate the verifications in `XMutexFactoryImplTest` and also introduce verifications specific to the synchronisation mechanisms. Addresses: antkorwin#9
Codecov Report
@@ Coverage Diff @@
## master #10 +/- ##
============================================
+ Coverage 99.16% 99.32% +0.15%
- Complexity 37 51 +14
============================================
Files 4 6 +2
Lines 120 148 +28
Branches 10 10
============================================
+ Hits 119 147 +28
Partials 1 1
Continue to review full report at Codecov.
|
|
As an aside, while developing this, I noticed that the project builds fine with Java 9, but fails with Java 10 or higher. It produces this error during the |
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds two new factories that generate
StampedLockandReadWriteLockinstances for applications that require more granular control over locking. The unit tests duplicate the verifications inXMutexFactoryImplTestand also introduce verifications specific to the synchronisation mechanisms.Some things I considered, but did not end up implementing:
XMutexFactoryImplTest,StampedLockFactoryTest, andReadWriteLockFactoryTest.XMutexFactorywere actually used and it was not clear to me why clients would provide a custom implementation.I would be happy to revisit these, of course.
Addresses: #9