Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable bugprone-* options in clang-tidy #315

Merged
merged 1 commit into from
Jan 22, 2025

Conversation

wxyucs
Copy link
Collaborator

@wxyucs wxyucs commented Jan 10, 2025

No description provided.

@wxyucs wxyucs added the kind/improvement Code improvements (variable/function renaming, refactoring, etc. ) label Jan 10, 2025
@wxyucs wxyucs self-assigned this Jan 10, 2025
@wxyucs wxyucs force-pushed the enable-linter-option-and-fix-issue branch 7 times, most recently from 802f564 to 0f376d7 Compare January 16, 2025 06:50
Copy link

codecov bot commented Jan 16, 2025

Codecov Report

Attention: Patch coverage is 97.43590% with 3 lines in your changes missing coverage. Please review.

@@            Coverage Diff             @@
##             main     #315      +/-   ##
==========================================
+ Coverage   87.67%   87.77%   +0.10%     
==========================================
  Files         134      134              
  Lines        8597     8624      +27     
==========================================
+ Hits         7537     7570      +33     
+ Misses       1060     1054       -6     
Flag Coverage Δ
cpp 87.77% <97.43%> (+0.10%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
common 88.69% <100.00%> (+0.22%) ⬆️
datacell 90.34% <ø> (+0.23%) ⬆️
index 91.16% <96.62%> (+0.09%) ⬆️
simd 69.28% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cefc6b2...4e2a5c8. Read the comment docs.

@wxyucs wxyucs force-pushed the enable-linter-option-and-fix-issue branch from 0f376d7 to df1e830 Compare January 17, 2025 03:36
Copy link
Collaborator

@LHT129 LHT129 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@inabao inabao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wxyucs wxyucs force-pushed the enable-linter-option-and-fix-issue branch 4 times, most recently from 79db631 to 3ee8196 Compare January 21, 2025 03:43
Copy link
Collaborator

@jiaweizone jiaweizone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wxyucs wxyucs force-pushed the enable-linter-option-and-fix-issue branch from 3ee8196 to 4e2a5c8 Compare January 21, 2025 03:54
@wxyucs wxyucs merged commit 74d5db1 into main Jan 22, 2025
15 of 16 checks passed
@wxyucs wxyucs deleted the enable-linter-option-and-fix-issue branch January 22, 2025 03:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/improvement Code improvements (variable/function renaming, refactoring, etc. ) size/L version/0.13
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants