add new interface for dataset to get/set num_results #313
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
inabao
requested review from
jiaweizone,
wxyucs,
LHT129 and
ShawnShawnYou
as code owners
inabao
added
the
kind/improvement
jiaweizone
reviewed
Jan 15, 2025
| NumResults(int64_t num_results) override { | ||
| // To maintain compatibility, we currently ensure that the values in NumResults and Dim are the same. | ||
| this->data_[NUM_RESULTS] = num_results; | ||
| this->data_[DIM] = num_results; |
There was a problem hiding this comment.
Have any dim and num_results are used together ?
There was a problem hiding this comment.
no, dim is input while num_results is output
Codecov ReportAttention: Patch coverage is @@ Coverage Diff @@
## main #313 +/- ##
==========================================
+ Coverage 90.81% 90.85% +0.03%
==========================================
Files 133 133
Lines 8429 8438 +9
==========================================
+ Hits 7655 7666 +11
+ Misses 774 772 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report in Codecov by Sentry.
|
inabao
force-pushed
the
add-num-results
branch
2 times, most recently
from
6623cf0 to
1f6e4ce
Compare
added 3 commits
January 22, 2025 16:21
Signed-off-by: jinjiabao.jjb <[email protected]>
Signed-off-by: jinjiabao.jjb <[email protected]>
Signed-off-by: jinjiabao.jjb <[email protected]>
inabao
force-pushed
the
add-num-results
branch
from
b6c4bd6 to
d063e5d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.