Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade the lcov version in github ci #311

Merged
merged 1 commit into from
Jan 13, 2025
Merged

upgrade the lcov version in github ci #311

merged 1 commit into from
Jan 13, 2025

Conversation

wxyucs
Copy link
Collaborator

@wxyucs wxyucs commented Jan 10, 2025

there is a coverage results collection issue in v2.2 of lcov, so we decided to upgrade the version lcov.

Copy link

codecov bot commented Jan 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

@@            Coverage Diff            @@
##           main     #311       +/-   ##
=========================================
+ Coverage      0   88.19%   +88.19%     
=========================================
  Files         0      139      +139     
  Lines         0     9504     +9504     
=========================================
+ Hits          0     8382     +8382     
- Misses        0     1122     +1122     

see 139 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 496b712...621a668. Read the comment docs.

@wxyucs wxyucs force-pushed the upgrade-lcov-in-ci branch 6 times, most recently from 5641ad6 to 5d75128 Compare January 10, 2025 14:37
@wxyucs wxyucs force-pushed the upgrade-lcov-in-ci branch 3 times, most recently from 5bced98 to fae4354 Compare January 10, 2025 17:40
Signed-off-by: Xiangyu Wang <[email protected]>
@wxyucs wxyucs force-pushed the upgrade-lcov-in-ci branch from fae4354 to 621a668 Compare January 10, 2025 19:03
@pull-request-size pull-request-size bot added size/M and removed size/S labels Jan 10, 2025
--ignore-errors mismatch,mismatch \
--ignore-errors count,count \
--output-file ${COVERAGE_DIR}/coverage.info

lcov --remove ${COVERAGE_DIR}/coverage.info '/usr/*' '*/build/*' '*/vsag/tests/*' --ignore-errors inconsistent,inconsistent --output-file ${COVERAGE_DIR}/coverage.info
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to check the coverage under the tools directory?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we just run unittest and functest in CI, so there is no coverage result about the codes in tools/

require_ci_to_pass: no
notify:
require_ci_to_pass: no
wait_for_ci: false
fixes:
- "/__w/vsag/::/"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok,Here change root source path ?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, use the relative path instead, the origin result uses the absolute path which makes the vsag/ directory deeper and meaningless in the pages of codecov.io

@wxyucs wxyucs added the kind/improvement Code improvements (variable/function renaming, refactoring, etc. ) label Jan 12, 2025
Copy link
Collaborator

@jiaweizone jiaweizone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@inabao inabao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wxyucs wxyucs merged commit c2d39e1 into main Jan 13, 2025
11 of 12 checks passed
@wxyucs wxyucs deleted the upgrade-lcov-in-ci branch January 13, 2025 03:08
Roxanne0321 pushed a commit to Roxanne0321/vsag that referenced this pull request Mar 3, 2025
jiacai2050 pushed a commit to jiacai2050/vsag that referenced this pull request Mar 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/improvement Code improvements (variable/function renaming, refactoring, etc. ) size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants