-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
upgrade the lcov version in github ci #311
Conversation
cc42693
to
ad27922
Compare
ad27922
to
cb20916
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅ @@ Coverage Diff @@
## main #311 +/- ##
=========================================
+ Coverage 0 88.19% +88.19%
=========================================
Files 0 139 +139
Lines 0 9504 +9504
=========================================
+ Hits 0 8382 +8382
- Misses 0 1122 +1122 see 139 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
5641ad6
to
5d75128
Compare
5bced98
to
fae4354
Compare
Signed-off-by: Xiangyu Wang <[email protected]>
fae4354
to
621a668
Compare
--ignore-errors mismatch,mismatch \ | ||
--ignore-errors count,count \ | ||
--output-file ${COVERAGE_DIR}/coverage.info | ||
|
||
lcov --remove ${COVERAGE_DIR}/coverage.info '/usr/*' '*/build/*' '*/vsag/tests/*' --ignore-errors inconsistent,inconsistent --output-file ${COVERAGE_DIR}/coverage.info |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need to check the coverage under the tools directory?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we just run unittest and functest in CI, so there is no coverage result about the codes in tools/
require_ci_to_pass: no | ||
notify: | ||
require_ci_to_pass: no | ||
wait_for_ci: false | ||
fixes: | ||
- "/__w/vsag/::/" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok,Here change root source path ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, use the relative path instead, the origin result uses the absolute path which makes the vsag/ directory deeper and meaningless in the pages of codecov.io
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: Xiangyu Wang <[email protected]>
Signed-off-by: Xiangyu Wang <[email protected]>
there is a coverage results collection issue in v2.2 of lcov, so we decided to upgrade the version lcov.