implement the interfaces for range search, filter in pyramid #310
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
inabao
requested review from
wxyucs,
LHT129,
ShawnShawnYou and
jiaweizone
as code owners
Codecov ReportAttention: Patch coverage is @@ Coverage Diff @@
## main #310 +/- ##
==========================================
+ Coverage 90.90% 91.01% +0.10%
==========================================
Files 133 133
Lines 8459 8607 +148
==========================================
+ Hits 7690 7834 +144
- Misses 769 773 +4
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report in Codecov by Sentry.
|
inabao
force-pushed
the
implementation-pyramid
branch
from
47e528e to
d788725
Compare
inabao
force-pushed
the
implementation-pyramid
branch
from
d788725 to
01adeda
Compare
LHT129
reviewed
Jan 15, 2025
LHT129
reviewed
Jan 15, 2025
inabao
force-pushed
the
implementation-pyramid
branch
2 times, most recently
from
1d78937 to
acf15c7
Compare
inabao
force-pushed
the
implementation-pyramid
branch
from
bf78d31 to
e479f2a
Compare
inabao
force-pushed
the
implementation-pyramid
branch
2 times, most recently
from
25b6deb to
d0f7f37
Compare
inabao
force-pushed
the
implementation-pyramid
branch
from
d0f7f37 to
f2ea40e
Compare
jiaweizone
reviewed
Jan 20, 2025
inabao
force-pushed
the
implementation-pyramid
branch
from
39205d3 to
9e54c7c
Compare
jiaweizone
reviewed
Jan 22, 2025
src/index/pyramid.cpp
Outdated
| reader->Read(offset, sizeof(size_t), &binary_size); | ||
| offset += sizeof(size_t); | ||
|
|
||
| auto new_eader = std::make_shared<SubReader>(reader, offset, binary_size); |
There was a problem hiding this comment.
new_eader -> new_reader ?
src/index/pyramid.h
Outdated
| #include "pyramid_zparameters.h" | ||
| #include "safe_allocator.h" | ||
|
|
||
| namespace vsag { | ||
|
|
||
| class SubReader : public Reader { | ||
| public: | ||
| SubReader(std::shared_ptr<Reader> parrent_reader, uint64_t start_pos, uint64_t size) |
There was a problem hiding this comment.
parrent_reader -> parent_reader
Signed-off-by: jinjiabao.jjb <[email protected]>
inabao
force-pushed
the
implementation-pyramid
branch
from
9e54c7c to
12602df
Compare
added 2 commits
January 23, 2025 15:20
Signed-off-by: jinjiabao.jjb <[email protected]>
Signed-off-by: jinjiabao.jjb <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#166