Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add github action to update the ci image automaticlly #307

Merged
merged 1 commit into from
Jan 13, 2025

Conversation

wxyucs
Copy link
Collaborator

@wxyucs wxyucs commented Jan 8, 2025

resolves: #300

@wxyucs wxyucs added the kind/improvement Code improvements (variable/function renaming, refactoring, etc. ) label Jan 8, 2025
@wxyucs wxyucs self-assigned this Jan 8, 2025
@wxyucs wxyucs force-pushed the add-docker-image-update-action branch from 03b5c20 to 1c86e12 Compare January 9, 2025 05:13
Copy link

codecov bot commented Jan 9, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #307   +/-   ##
=======================================
  Coverage   49.80%   49.80%           
=======================================
  Files         331      331           
  Lines       32705    32705           
  Branches     4129     4129           
=======================================
  Hits        16289    16289           
  Misses      15555    15555           
  Partials      861      861           

see 6 files with indirect coverage changes

@wxyucs wxyucs requested review from inabao and LHT129 January 10, 2025 02:49
Copy link
Collaborator

@jiaweizone jiaweizone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

on:
push:
branches: [ "main" ]

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

triggered when merge into main everytime?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, for test docker build and push, the trigger condition will be modified again if I am sure it works well

Copy link
Collaborator

@LHT129 LHT129 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wxyucs wxyucs merged commit 4b3c3d6 into main Jan 13, 2025
11 checks passed
@wxyucs wxyucs deleted the add-docker-image-update-action branch January 13, 2025 03:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/improvement Code improvements (variable/function renaming, refactoring, etc. ) size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

support dev/ci image publish automatically
3 participants