add distances for test_performance #305
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: jinjiabao.jjb <[email protected]>
inabao
force-pushed
the
add-distances-for-test-performance
branch
from
4962088 to
de60643
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅ |
jiaweizone
reviewed
Jan 9, 2025
tools/eval_dataset.cpp
Outdated
| H5::DataSet dataset = file.openDataSet("/distances"); | ||
| H5::DataSpace dataspace = dataset.getSpace(); | ||
| H5::FloatType datatype(H5::PredType::NATIVE_FLOAT); | ||
| dataset.read(obj->neighbors_.get(), datatype, dataspace); |
There was a problem hiding this comment.
dataset.read(obj->neighbors_.get(), datatype, dataspace);
-->
dataset.read(obj->distances_.get(), datatype, dataspace);
tools/test_performance.cpp
Outdated
| @@ -32,6 +32,16 @@ using namespace nlohmann; | |||
| using namespace spdlog; | |||
| using namespace vsag; | |||
|
|
|||
| float | |||
| InnerProduct(const void* pVect1, const void* pVect2, const void* qty_ptr) { | |||
There was a problem hiding this comment.
Where usage this method ?
There was a problem hiding this comment.
I have removed this function
Signed-off-by: jinjiabao.jjb <[email protected]>
inabao
added
the
kind/improvement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.