introduce third party yaml-cpp for tools #294
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LHT129
added
the
kind/improvement
wxyucs
reviewed
Jan 3, 2025
extern/yaml-cpp/yaml-cpp.cmake
Outdated
| URL_HASH MD5=1d2c7975edba60e995abe3c4af6480e5 | ||
| DOWNLOAD_NO_PROGRESS 1 | ||
| INACTIVITY_TIMEOUT 5 | ||
| TIMEOUT 60md5 |
There was a problem hiding this comment.
what is the meaning of 60md5?
wxyucs
requested changes
Jan 3, 2025
extern/yaml-cpp/yaml-cpp.cmake
Outdated
| URL https://github.com/jbeder/yaml-cpp/archive/refs/tags/0.8.0.tar.gz | ||
| # this url is maintained by the vsag project, if it's broken, please try | ||
| # the latest commit or contact the vsag project | ||
| http://vsagcache.oss-rg-china-mainland.aliyuncs.com/yaml-cpp/v3.1.tar.gz |
There was a problem hiding this comment.
change v3.1.tar.gz to 0.8.0.tar.gz
Codecov ReportAll modified and coverable lines are covered by tests ✅ @@ Coverage Diff @@
## main #294 +/- ##
==========================================
+ Coverage 49.80% 49.98% +0.17%
==========================================
Files 331 331
Lines 32705 32703 -2
Branches 4129 4128 -1
==========================================
+ Hits 16289 16345 +56
+ Misses 15555 15494 -61
- Partials 861 864 +3 |
LHT129
force-pushed
the
yamlcpp
branch
2 times, most recently
from
6e38b16 to
9eabb0b
Compare
Signed-off-by: LHT129 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.