introduce new eval tool: eval_performance #234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
LHT129
commented
Dec 19, 2024
LHT129
commented
- the same as test_performance but support more
- add Monitor, EvalCase to extends the eval
- use argparse for command line
LHT129
added
the
kind/improvement
LHT129
force-pushed
the
eval
branch
2 times, most recently
from
57e1fa9 to
f5bf68f
Compare
LHT129
force-pushed
the
eval
branch
4 times, most recently
from
6be5a00 to
a3fc5cd
Compare
wxyucs
reviewed
Dec 30, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅ @@ Coverage Diff @@
## main #234 +/- ##
==========================================
- Coverage 90.97% 90.15% -0.82%
==========================================
Files 114 116 +2
Lines 6947 7022 +75
==========================================
+ Hits 6320 6331 +11
- Misses 627 691 +64
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report in Codecov by Sentry.
|
LHT129
force-pushed
the
eval
branch
3 times, most recently
from
6394d45 to
21461fd
Compare
LHT129
force-pushed
the
eval
branch
3 times, most recently
from
1e086b5 to
1a02778
Compare
LHT129
force-pushed
the
eval
branch
2 times, most recently
from
9e50409 to
ec7edd0
Compare
inabao
approved these changes
Jan 16, 2025
tools/eval/build_eval_case.h
Outdated
|
|
||
| argparse::ArgumentParser& parser_; | ||
| }; | ||
| } // namespace eval |
| } else if (type == "search") { | ||
| return std::make_shared<SearchEvalCase>(dataset_path, index_path, index.value(), config); | ||
| } else { | ||
| return nullptr; |
There was a problem hiding this comment.
Here, we can directly throw an error and log it, as it seems there is no nullptr check being performed outside.
wxyucs
reviewed
Jan 16, 2025
LHT129
force-pushed
the
eval
branch
4 times, most recently
from
d1d2610 to
dbe0fe3
Compare
- the same as test_performance but support more - add Monitor, EvalCase to extends the eval - use argparse for command line Signed-off-by: LHT129 <[email protected]>
Carrot-77
pushed a commit
to Carrot-77/vsag
that referenced
this pull request
Jan 20, 2025
- the same as test_performance but support more - add Monitor, EvalCase to extends the eval - use argparse for command line Signed-off-by: LHT129 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.